Fix suspension persistence to materialize app state before shutdown save - #4353
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4353 +/- ##
==========================================
- Coverage 89.86% 89.85% -0.02%
==========================================
Files 253 253
Lines 9652 9659 +7
Branches 1476 1481 +5
==========================================
+ Hits 8674 8679 +5
Misses 734 734
- Partials 244 246 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChrisPulman
marked this pull request as ready for review
May 6, 2026 23:26
glennawatson
approved these changes
May 6, 2026
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix
What is the current behavior?
Closes #4352
What is the new behavior?
Summary
ReactiveUIsuspension persistence soShouldPersistStatenow forces app state materialization beforeSaveStateruns, covering first-launch shutdown paths and missed launch-signal ordering.Testing
dotnet build src\tests\ReactiveUI.Tests\ReactiveUI.Tests.csproj --no-restoreSuspensionHostExtensionsTestsandSuspensionHostExtensionsAotTestsonnet8.0,net9.0, andnet10.0SuspensionHost*sweep onnet10.0; all passedWhat might this PR break?
Checklist
mainbranchAdditional information